Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace react-resize-detector #2433

Open
YuHsuan-Hwang opened this issue Nov 15, 2024 · 0 comments · May be fixed by #2452
Open

Replace react-resize-detector #2433

YuHsuan-Hwang opened this issue Nov 15, 2024 · 0 comments · May be fixed by #2452
Assignees
@YuHsuan-Hwang
Labels
code maintenance For issues relating to code maintenance and quality

Comments

@YuHsuan-Hwang
Copy link
Collaborator

react-resize-detector v9 is producing warnings with React 18. The child function pattern <ReactResizeDetector/> is removed from react-resize-detector v10. Only the useResizeDetector hook is supported, which can only applied with functional components.
We could consider replacing react-resize-detector with blueprint <ResizeSensor/> + throttling.
@YuHsuan-Hwang YuHsuan-Hwang added the code maintenance For issues relating to code maintenance and quality label Nov 15, 2024
@YuHsuan-Hwang YuHsuan-Hwang mentioned this issue Nov 15, 2024
Merged
12 tasks
@YuHsuan-Hwang YuHsuan-Hwang self-assigned this Dec 19, 2024
@YuHsuan-Hwang YuHsuan-Hwang linked a pull request Dec 20, 2024 that will close this issue
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuHsuan-Hwang YuHsuan-Hwang

Labels
code maintenance For issues relating to code maintenance and quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Yuhsuan/replace react resize detector CARTAvis/carta-frontend
1 participant
@YuHsuan-Hwang