Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to node 16 #194

Closed
tobiasnteireho opened this issue Jan 7, 2022 · 4 comments · Fixed by #202
Closed

upgrade to node 16 #194

tobiasnteireho opened this issue Jan 7, 2022 · 4 comments · Fixed by #202

Comments

@tobiasnteireho
Copy link
Contributor

node 16 is current active lts. Attempting to upgrade to 16.13.1 yields following error at steal transpilation step

Build has failed.  TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of SourceMapGenerator
    at writeFile (node:fs:2106:5)
    at /vol/data/sites/hydra.a2jauthor.org/a2jviewer-node16/node_modules/pdenodeify/lib/main.js:18:20
    at new Promise (<anonymous>)
    at /vol/data/sites/hydra.a2jauthor.org/a2jviewer-node16/node_modules/pdenodeify/lib/main.js:10:12
    at /vol/data/sites/hydra.a2jauthor.org/a2jviewer-node16/node_modules/steal-tools/lib/bundle/write_bundles.js:64:13
    at async Promise.all (index 1) {
  code: 'ERR_INVALID_ARG_TYPE'
}
Warning: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of SourceMapGenerator Use --force to continue.

Aborted due to warnings.
@tobiasnteireho
Copy link
Contributor Author

fails in node 14 as well

Build has failed.  TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of SourceMapGenerator
    at writeFile (fs.js:1491:5)
    at /vol/data/sites/hydra.a2jauthor.org/a2jviewer-node16/node_modules/pdenodeify/lib/main.js:18:20
    at new Promise (<anonymous>)
    at /vol/data/sites/hydra.a2jauthor.org/a2jviewer-node16/node_modules/pdenodeify/lib/main.js:10:12
    at /vol/data/sites/hydra.a2jauthor.org/a2jviewer-node16/node_modules/grunt-steal/node_modules/steal-tools/lib/bundle/write_bundles.js:64:13
    at async Promise.all (index 1) {
  code: 'ERR_INVALID_ARG_TYPE'
}
Warning: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of SourceMapGenerator Use --force to continue.

@mikemitchel
Copy link
Contributor

could be an issue with StealJS - I think it might required an upgrade to 2.x for Steal to work with Node14/16 @tobiasnteireho
https://stealjs.com/docs/StealJS.topics.migrating-two.html

@tobiasnteireho
Copy link
Contributor Author

tobiasnteireho commented Jan 10, 2022

This error still occurs with steal 2 and steal 2 yields a bad engine error in node 16 stealjs/steal-tools#1161

@tobiasnteireho
Copy link
Contributor Author

looks like setting sourcemaps:false in Gruntfile resolves this. Steal upgrade works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants