-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROPOSAL] Add some Unit Test for CCExtractor #911
Comments
This is part of the ccx_testsuite where it's purpose is to Test CCExtractor. There is already an issue there for writing unit tests. |
I think that issue is to write unit tests for ccx_testsuite, instead of CCExtractor. |
Just to be clear:
However, if tests can be added for CCExtractor, why not? |
@canihavesomecoffee don't we have CI tests of CCExtractor for pull requests already, so what will make unit tests different from that? |
Those are integration tests - end to end. But they don't really test individual parts of the code, so when a commit break something all we know from the CI is that something broke :-) I don't know however how unit tests would work for us, with the huge amount of spaguetti code we've accumulated over the years. I think we should try to have unit tests for Rust code as we port/rewrite, but I wouldn't bother with the C code. |
Please prefix your issue with one of the following: [BUG], [PROPOSAL], [QUESTION].
CCExtractor version (using the --version parameter preferably) : X.X
In raising this issue, I confirm the following (please check boxes, eg [X]):
My familiarity with the project is as follows (check one, eg [X]):
Necessary information
-autoprogram
Video links
Please make the affected input file available for us (no screenshots, those don't help!). Public links to Dropbox, Google Drive, etc, are all fine. If it is not possible to make it available publicly, send us a private invitation (both Dropbox and Google Drive allow that). In this case we will download the file and upload it to the private developer repository.
Do not upload your file to any location that will require us to sign up or endure a wait list, slow downloads, etc. If your upload expires make sure you keep it active somehow (replace links if needed). Keep in mind that while we go over all tickets some may take a few days, and it's important we have the file available when we actually need it.
Additional information
We need to add some unit test to CCExtractor to make sure things run properly (as the latest unit test commit is a year ago)
PS: Make sure you set an alert in GitHub so you get notifications about your ticket. We may need to ask questions and we do everything inside GitHub's system.
The text was updated successfully, but these errors were encountered: