Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default name arguments for NumPyro sites from non-model classes #198

Closed
damonbayer opened this issue Jun 17, 2024 · 1 comment · Fixed by #306
Closed

Remove default name arguments for NumPyro sites from non-model classes #198

damonbayer opened this issue Jun 17, 2024 · 1 comment · Fixed by #306
Assignees
@sbidari
Labels
clean up Good code that could be better pyrenew related to pyrenew internals
Milestone
🦆 Olorotitan

Comments

@damonbayer
Copy link
Collaborator

Some code has default names for NumPyro sites baked in.

Ex:

https://github.com/CDCgov/multisignal-epi-inference/blob/428bcc4f3ba4840d8209653ecbc285702141c209/model/src/pyrenew/observation/negativebinomial.py#L17-L23

This could lead to problems if there are multiple random variables constructed from the same class. At this low level, we should require users to specify the site names.
@damonbayer damonbayer added development task clean up Good code that could be better labels Jun 17, 2024
@dylanhmorris dylanhmorris mentioned this issue Jun 20, 2024
Merged
@dylanhmorris
Copy link
Collaborator

I agree with this.

@damonbayer damonbayer added pyrenew related to pyrenew internals and removed development task labels Jul 12, 2024
@damonbayer damonbayer mentioned this issue Jul 15, 2024
Merged
@sbidari sbidari self-assigned this Jul 17, 2024
@sbidari sbidari mentioned this issue Jul 24, 2024
Merged
@sbidari sbidari linked a pull request Jul 24, 2024 that will close this issue
remove default name arg #306
Merged
@damonbayer damonbayer added this to the 🦆 Olorotitan milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbidari sbidari

Labels
clean up Good code that could be better pyrenew related to pyrenew internals
Projects
None yet
Milestone
🦆 Olorotitan
Development

Successfully merging a pull request may close this issue.

remove default name arg CDCgov/PyRenew
3 participants
@dylanhmorris @damonbayer @sbidari