Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept the filename or other string as a header or query parameter on data submissions #2314

Closed
jimduff-usds opened this issue Sep 22, 2021 · 0 comments
Assignees
Labels
pipeline Cle, Jim, Yemi, Carlos, Gage, Derek, Ott

Comments

@jimduff-usds
Copy link
Contributor

jimduff-usds commented Sep 22, 2021

@loripusey had this good idea: Some submitters think in terms of files, so as a convenience to them, we could accept a name for the payload they are submitting, and they could choose to pass in a filename. Then we'll send it back to them later, as part or lineage API.

Note: The API has no idea what file was used to create the payload. The API just sees bytes in the body payload, and doesn't know where it came from. hence the need for the user to send a name string separately.

Tasks:

  • Accept a payloadName as an additional header or query param or both.
  • Create a new payload_name varchar in the ACTION table, and store it there if it exists, else null.
  • Also create an index on this column - you could see lookups being done on this in the future.
  • Add this to the release notes - this is a customer facing feature.
  • Establish what the format for this filename is. E.g. length, allowed characters, etc. Need to make sure to sanitize this value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipeline Cle, Jim, Yemi, Carlos, Gage, Derek, Ott
Projects
None yet
Development

No branches or pull requests

1 participant