Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove role restrictions on patient bulk upload #4371

Closed
emmastephenson opened this issue Oct 3, 2022 · 1 comment · Fixed by #4722
Closed

Remove role restrictions on patient bulk upload #4371

emmastephenson opened this issue Oct 3, 2022 · 1 comment · Fixed by #4722
Assignees

Comments

@emmastephenson
Copy link
Contributor

Background

Patient bulk upload is currently only available to SimpleReport site admins (i.e., engineers). The final stage of opening the feature to end users will be changing the role restrictions to allow regular SimpleReport admins access.

Action requested

Change the authorization configuration on UploadService.processPersonCSV from RequireGlobalAdminUser to RequirePermissionEditFacility. (Technically this is a patient-related operation, but given that it will affect many patients this permission level seems more appropriate).

https://github.com/CDCgov/prime-simplereport/blob/master/backend/src/main/java/gov/cdc/usds/simplereport/service/UploadService.java#L92-L92

Acceptance Criteria

Bulk upload is available to SimpleReport admin users, not just site admins.

Additional context

This is the last piece of work to do for patient bulk upload - everything else (UI updates, error messaging, etc) should be finished before this is merged.

@georgehager
Copy link
Contributor

I've looked at what's required for this, holding until other patient bulk upload changes are merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants