You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following the merge of PR #4722 , there is a known regression for the Patient Bulk Upload feature locally - we are no longer able to do patient bulk uploads locally without Okta. Note this only affects local dev testing, and it is still possible to do patient bulk upload locally with Okta.
Requested Action
Investigate the cause of the regression, most likely related to the DemoOktaRepository not mocking Okta properly for async processing
Implement a resolution, probably by updating DemoOktaRepository
Acceptance Criteria
Devs are able to upload a valid patient csv locally without Okta running
Additional Information
Doing patient bulk uploads locally without Okta is particularly helpful when testing a patient file upload for any errors before performing them in prod for support requests. Note however that validation can still be performed successfully even if the async service (PatientBulkUploadServiceAsync) does not run, as validation is performed before async processing.
Also note that when uploading a valid patient csv without okta, the backend will return success but will not actually add any patients. This is expected - since there are no errors in validation, the non-async service returns success while the async service continues processing and fails only when it runs into permission requirements on on the savePatients method.
More context from Zedd:
I tested by removing the permission requirement on savePatients and it works, it craps out on Organization currentOrganization = organizationService.getCurrentOrganization();
Which means we need to better mock stuff with DemoOktaRepository for local dev
The text was updated successfully, but these errors were encountered:
georgehager
changed the title
[BUG] Fix DemoOktaRepository to get patient bulk uploads working locally
[BUG] Patient Bulk Upload does not work locally without Okta
Dec 21, 2022
Background
Following the merge of PR #4722 , there is a known regression for the Patient Bulk Upload feature locally - we are no longer able to do patient bulk uploads locally without Okta. Note this only affects local dev testing, and it is still possible to do patient bulk upload locally with Okta.
Requested Action
DemoOktaRepository
not mocking Okta properly for async processingDemoOktaRepository
Acceptance Criteria
Devs are able to upload a valid patient csv locally without Okta running
Additional Information
Doing patient bulk uploads locally without Okta is particularly helpful when testing a patient file upload for any errors before performing them in prod for support requests. Note however that validation can still be performed successfully even if the async service (
PatientBulkUploadServiceAsync
) does not run, as validation is performed before async processing.Also note that when uploading a valid patient csv without okta, the backend will return success but will not actually add any patients. This is expected - since there are no errors in validation, the non-async service returns success while the async service continues processing and fails only when it runs into permission requirements on on the
savePatients
method.More context from Zedd:
The text was updated successfully, but these errors were encountered: