Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Patient Bulk Upload does not work locally without Okta #4900

Closed
emyl3 opened this issue Dec 21, 2022 · 0 comments · Fixed by #4950
Closed

[BUG] Patient Bulk Upload does not work locally without Okta #4900

emyl3 opened this issue Dec 21, 2022 · 0 comments · Fixed by #4950
Assignees
Labels

Comments

@emyl3
Copy link
Collaborator

emyl3 commented Dec 21, 2022

Background

Following the merge of PR #4722 , there is a known regression for the Patient Bulk Upload feature locally - we are no longer able to do patient bulk uploads locally without Okta. Note this only affects local dev testing, and it is still possible to do patient bulk upload locally with Okta.

Requested Action

  • Investigate the cause of the regression, most likely related to the DemoOktaRepository not mocking Okta properly for async processing
  • Implement a resolution, probably by updating DemoOktaRepository

Acceptance Criteria

Devs are able to upload a valid patient csv locally without Okta running

Additional Information

Doing patient bulk uploads locally without Okta is particularly helpful when testing a patient file upload for any errors before performing them in prod for support requests. Note however that validation can still be performed successfully even if the async service (PatientBulkUploadServiceAsync) does not run, as validation is performed before async processing.

Also note that when uploading a valid patient csv without okta, the backend will return success but will not actually add any patients. This is expected - since there are no errors in validation, the non-async service returns success while the async service continues processing and fails only when it runs into permission requirements on on the savePatients method.

More context from Zedd:

I tested by removing the permission requirement on savePatients and it works, it craps out on Organization currentOrganization = organizationService.getCurrentOrganization();
Which means we need to better mock stuff with DemoOktaRepository for local dev

@georgehager georgehager changed the title [BUG] Fix DemoOktaRepository to get patient bulk uploads working locally [BUG] Patient Bulk Upload does not work locally without Okta Dec 21, 2022
@emmastephenson emmastephenson self-assigned this Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants