We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/CGAL/cgal/blame/187409888bd8590ad71f2a4912f53d9014a6cc27/Filtered_kernel/include/CGAL/Filtered_kernel/internal/Static_filters/Power_side_of_oriented_power_sphere_3.h#L374 As far as I can see, int_tmp_result can only be ±1 (line 348 or 354), and cmp is a copy, so the comparison cmp!=0 should always be true. Since the if branch ends with a return, this suggests that the next 170 lines are unreachable. Did I misread the code? (if I was more serious, I would add an assertion and run some tests to confirm, or check if there is a coverage report of CGAL's testsuite somewhere online) See also #2067 since this is the version with 4 points.
int_tmp_result
cmp
cmp!=0
if
return
The text was updated successfully, but these errors were encountered:
Smells like #5207?
Sorry, something went wrong.
Ah, yes, same generator, similar strange code for another predicate. I had completely forgotten about #5207.
afabri
Successfully merging a pull request may close this issue.
https://github.com/CGAL/cgal/blame/187409888bd8590ad71f2a4912f53d9014a6cc27/Filtered_kernel/include/CGAL/Filtered_kernel/internal/Static_filters/Power_side_of_oriented_power_sphere_3.h#L374
As far as I can see,
int_tmp_result
can only be ±1 (line 348 or 354), andcmp
is a copy, so the comparisoncmp!=0
should always be true. Since theif
branch ends with areturn
, this suggests that the next 170 lines are unreachable. Did I misread the code?(if I was more serious, I would add an assertion and run some tests to confirm, or check if there is a coverage report of CGAL's testsuite somewhere online)
See also #2067 since this is the version with 4 points.
The text was updated successfully, but these errors were encountered: