Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated Functions in Annotations_Pipeline & New Ensembl Notation #317

Closed
jscaber opened this issue Mar 14, 2017 · 2 comments
Closed

Deprecated Functions in Annotations_Pipeline & New Ensembl Notation #317

jscaber opened this issue Mar 14, 2017 · 2 comments
Labels

Comments

@jscaber
Copy link
Member

jscaber commented Mar 14, 2017

I have rerun the annotations pipeline on the newest annotations.
There are some new changes in the recent ensembl releases: Whereas the GTF still has "ENSPXXX" notation, the .pep. file and the .cdna. file now have transcript/protein notation with a suffix: "ENSPXXX.1" etc. Because there are multiple steps at which these tables are combined we need to find a solution to this:
Options:

  • Remove ".1" suffix when loading these databases (I have implemented this)
  • Create Additional Columns

While looking at this I found another error that used to fail the pipeline. Pipeline_annotations relies on peptide2cdna methods, which in turn rely on an ancient library written by Adnreas: alignment_light. The library still exists but has been massively rewritten. Given that the cdna/peptide functionality has not been used I have taken the entirety of these function and methods out, as they need to be rewritten from scratch if at all needed (what was its purpose?). The cdna fasta is now made from ensembl cdna data only.

see Pull Request #318
Also See Pull Request in CGATPipelines CGATOxford/CGATPipelines#312

@AndreasHeger
Copy link
Member

Hi @jscaber , thanks, taking these out is fine - they were mostly useful for gene-prediction tasks and comparative genomics, not so much our focus now.

@sebastian-luna-valero
Copy link
Member

Many thanks @jscaber and @AndreasHeger !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants