-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a_min and m_min adjustable #963
Comments
Finally had a chance to run this case. I believe the change to a_min and m_min is within variability in the CESM. I have run for 50 years so far, but likely will do 100 just to be safe. |
Ok. I have new diagnostics for 100 years and have included contour plots. There is kind of a weird systematic difference of plus or minus 10cm here. Might be just within variability though. |
Based on this, I just feel that we should leave these hard-coded with the new values. |
Using a_min=1.e-11 and m_min=1.e-10, quite some ufs-weather-model regression tests fail with: Before digging into this more, are these what y'all are thinking the new default values should be? |
Fair enough. We only tested these in two coupled models. So, we should add them as namelist values. |
Interesting that the 2 climate models do not fail but tests in UFS do. Could that be related to initialization? As noted above, the larger values were originally included to keep the code from blowing up, a symptom of which is large velocities that would cause transport departure points to be outside of neighboring cells. I agree with Dave that it makes sense to include them as namelist values, and for now keep the old values as the default with a recommendation to try cranking them down. |
It's possible that dt_dyn or other settings used in UFS should/can be adjusted but I wanted to mention these regression tests first |
Departure points out of bounds is like a CFL violation. You can try adjusting timesteps when you are close to the stability threshold. However, if a_min and m_min set to the current values works in the current UFS suite, I would recommend sticking with that. |
It may be related to initialization...in some UFS regression tests CICE ICs are from CPC reanalysis with SIS2->CICE processing. I'll make EMC/CICE issue to follow up but hardcoding these so small is a breaking change at the moment. |
CICE/cicecore/cicedyn/dynamics/ice_dyn_shared.F90
Line 68 in b109fa4
CICE/cicecore/cicedyn/dynamics/ice_dyn_shared.F90
Line 69 in b109fa4
a_min
andm_min
are fixed parameters in ice_dyn_shared.F90, which were originally intended to prevent the dynamics code from blowing up when the ice area or volume are very small. Tests in E3SM indicate that these can be as small as 1.e-11 and 1.e-10, respectively (although that might be a function of the driver code in E3SM), and that reducing them improves the simulation results. I recommend addinga_min
to namelist and settingm_min=10*a_min
for easier testing.I'm curious whether any model blows up with such small values, or if E3SM's stability is unique and worth a closer look.
The text was updated successfully, but these errors were encountered: