Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExistingFileValidator fail for file > 2GB on Windows #312

Closed
zyzheng opened this issue Aug 22, 2019 · 2 comments
Closed

ExistingFileValidator fail for file > 2GB on Windows #312

zyzheng opened this issue Aug 22, 2019 · 2 comments
Labels

Comments

@zyzheng
Copy link

zyzheng commented Aug 22, 2019

When using with a video file that is larger than 2GB, ExistingFileValidator always fails even if the file actually exists.

From the code, it's using stat to check file stats. According to Microsoft document, it seems that function only support up to 32bit file length, which I assume is the cause for this problem.

I think using _stat64 on Windows should fix it, but not sure about other operating system.

@henryiii
Copy link
Collaborator

I believe other platforms return 64-bits from stat. Probably needs a check for windows + 64 bit...

@henryiii henryiii added the bug label Aug 22, 2019
@steffenb7333
Copy link

Since it is a CMAKE-define (CLI11_CXX_STD) would it not be an option to use std::filesystem::* if CLI11 is/was compiled using c++17 and/or a Feature Testing Macro indicates it is available?

@phlptp phlptp mentioned this issue Nov 10, 2019
@phlptp phlptp closed this as completed Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants