Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_me_dict function has some hand-picking of me_id values for handling 2D MEs that is now obsolete #8

Open
gbenelli opened this issue Sep 19, 2024 · 1 comment
Assignees

Comments

@gbenelli
Copy link
Contributor

IT seems this line has some obsolete if to handle 2D MEs: the logic should check the y_bin/bin/min/max values in the DF (in case queries could include both 1D and 2D histos, otherwise, just check for column names in the DF).

if me_id >= 96:

@roy-cruz
Copy link
Contributor

roy-cruz commented Sep 28, 2024

Fixed it with the latest commit which implements a new class, MEData which handles data from DIALS. Please check corresponding PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants