-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PD_PEAK needs diffractogram_id? and some musings on it's use in PD_AMORPHOUS #129
Comments
If |
Consider the setup in the data below. There are two diffractograms, each with two phases - one normal crystalline, one be amorphous. Each diffractogram has been modelled with the same two phases, so there are only two data blocks containing phase information. How do we indicate that the peaks in each of the diffractograms actually belong to the same amorphous phase, and that the peaks in the amorphous phase are represented by two different sets of peak?
Some ideas (of course, suggestions for better names are more than welcome):
where Similar, but split up
where A more CIF1.1-style solution
. In all of these, |
This might be a little "stream of conciousness"y.
.
From rereading #23 and the definition of
PD_PEAK
, I have two questions:PD_PEAK
have a_pd_peak.diffractogram_id
dataitem?_pd_peak.diffractogram_id
be a category key?_pd_peak.id
is also used inPD_AMORPHOUS
,PD_BACKGROUND
andREFLN
.PD_AMORPHOUS
is keyed onpeak_id
andphase_id
.PD_BACKGROUND
is keyed onid
anddiffractogram_id
.REFLN
is keyed on_refln.index_h|k|l
and_pd_refln.phase_id
.Consider a simple example of a synthetic mixture of
CRYST_PHASE
andAMOR_PHASE
(think quartz and silica fume) as below (ignoredata_diffraction_pattern_2
for now...).CRYST_PHASE
is a bog-standard normal crystal structure.AMOR_PHASE
is defined by some peaks. How doesAMOR_PHASE
know where to go to get it's peaks?.
I also stumbled upon another issue: Consider the same phases in a second synthetic mixture (now unignore
data_diffraction_pattern_2
), where it is the exact same materials but in different amounts . Also assume I do a constrained refinement, so other parameters that should be the same, are the same.It makes sense to have a single
AMOR_PHASE
, as it literally is the same material. But I don't think we can point the same phase to two different diffraction patterns which have different PD_PEAK parameters (in this case, intensity). We need a way to designate relative intensities in the amorphous phase. Also, in the case of multiple diffraction patterns, how can we point to differentdiffractogram_id
s.The PD_PEAK category description, just FYi
I need to have a think.
The text was updated successfully, but these errors were encountered: