You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello! I noticed a strange behaviour for the function load_match() with (admittedly also a somewhat strange/unusual) match file (see kv333_3.txt(matchfile as txt file) attached):
What's strange about the match file: For measure 198, the beats get counted up to 16 (instead of 2) - this is a result of a change on the matchfile to represent an extended measure (see score image attached). In the original version of the matchfile (see kv333_3_orig.txt attached), all notes for this measure 198 were split on two beats, and most had the same offset, duration, and onsetInBeats and offsetInBeats (only shifted by 1 at the point where the beat split occurred, which was then set at the triller C (198:6 in the image attached)). In the updated version (kv333_3.txt), the beats in measure:beat get counted up, the offset is updated according to the note position relative to the beat, the duration is updated to the notated score duration and the onsetInBeats and offsetInBeats are added up according to the duration.
As a result of all these changes, the onsetInBeats and offsetInBeats in total add up, so for all the notes after this extended measure (starting from score note n2848 / performed note 2848) the onsetInBeats and offsetInBeats values were adjusted by shifting them for 13 beats.
What's the strange behaviour now when loading a score from this matchfile using load_match(): the note_array() from this score_part only includes notes up to score note n2847 which is the last note of the extended measure. The rest of the score part is not processed.
It seems that in this match file from line 2873 and forwards the snotes are missing their closing parenthesis. What should we do with corrupted match files like this, should we have some kind of type checking?
Hello! I noticed a strange behaviour for the function
load_match()
with (admittedly also a somewhat strange/unusual) match file (seekv333_3.txt
(matchfile as txt file) attached):kv333_3_orig.txt
attached), all notes for this measure 198 were split on two beats, and most had the sameoffset
,duration
, andonsetInBeats
andoffsetInBeats
(only shifted by 1 at the point where the beat split occurred, which was then set at the triller C (198:6 in the image attached)). In the updated version (kv333_3.txt
), the beats inmeasure:beat
get counted up, theoffset
is updated according to the note position relative to the beat, theduration
is updated to the notated score duration and theonsetInBeats
andoffsetInBeats
are added up according to the duration.As a result of all these changes, the
onsetInBeats
andoffsetInBeats
in total add up, so for all the notes after this extended measure (starting from score noten2848
/ performed note2848
) theonsetInBeats
andoffsetInBeats
values were adjusted by shifting them for 13 beats.load_match()
: thenote_array()
from this score_part only includes notes up to score noten2847
which is the last note of the extended measure. The rest of the score part is not processed.[kv333_3_orig.txt](https://github.com/CPJKU/partitura/files/9809449/kv333_3_orig.txt) [kv333_3.txt](https://github.com/CPJKU/partitura/files/9809450/kv333_3.txt)
The text was updated successfully, but these errors were encountered: