Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_match(score_part=True) doesn't load all notes in score_part #162

Closed
huispaty opened this issue Oct 18, 2022 · 1 comment
Closed

load_match(score_part=True) doesn't load all notes in score_part #162

huispaty opened this issue Oct 18, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@huispaty
Copy link
Collaborator

Hello! I noticed a strange behaviour for the function load_match() with (admittedly also a somewhat strange/unusual) match file (see kv333_3.txt(matchfile as txt file) attached):

  • What's strange about the match file: For measure 198, the beats get counted up to 16 (instead of 2) - this is a result of a change on the matchfile to represent an extended measure (see score image attached). In the original version of the matchfile (see kv333_3_orig.txt attached), all notes for this measure 198 were split on two beats, and most had the same offset, duration, and onsetInBeats and offsetInBeats (only shifted by 1 at the point where the beat split occurred, which was then set at the triller C (198:6 in the image attached)). In the updated version (kv333_3.txt), the beats in measure:beat get counted up, the offset is updated according to the note position relative to the beat, the duration is updated to the notated score duration and the onsetInBeats and offsetInBeats are added up according to the duration.
    As a result of all these changes, the onsetInBeats and offsetInBeats in total add up, so for all the notes after this extended measure (starting from score note n2848 / performed note 2848) the onsetInBeats and offsetInBeats values were adjusted by shifting them for 13 beats.
  • What's the strange behaviour now when loading a score from this matchfile using load_match(): the note_array() from this score_part only includes notes up to score note n2847 which is the last note of the extended measure. The rest of the score part is not processed.

grafik

[kv333_3_orig.txt](https://github.com/CPJKU/partitura/files/9809449/kv333_3_orig.txt) [kv333_3.txt](https://github.com/CPJKU/partitura/files/9809450/kv333_3.txt)
@manoskary manoskary added the wontfix This will not be worked on label May 10, 2023
@manoskary manoskary added bug Something isn't working and removed wontfix This will not be worked on labels May 10, 2023
@manoskary
Copy link
Member

It seems that in this match file from line 2873 and forwards the snotes are missing their closing parenthesis. What should we do with corrupted match files like this, should we have some kind of type checking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants