Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow redefinition of names in guppy modules #326

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

doug-q
Copy link
Contributor

@doug-q doug-q commented Jul 25, 2024

closes #307

@doug-q doug-q requested a review from a team as a code owner July 25, 2024 07:13
@doug-q doug-q requested review from croyzor and mark-koch July 25, 2024 07:13
@doug-q
Copy link
Contributor Author

doug-q commented Jul 25, 2024

Adding Mark as a reviewer because I do not expect this to be acceptable as-is

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.68%. Comparing base (6698b75) to head (9a04f63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   92.67%   92.68%   +0.01%     
==========================================
  Files          45       45              
  Lines        5105     5100       -5     
==========================================
- Hits         4731     4727       -4     
+ Misses        374      373       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mark-koch mark-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge this as is to improve the experience of notebook users. It matches the regular behaviour of Python anyways.

We can always revisit this later if it leads to problems down the road

@doug-q doug-q added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 314409c Jul 25, 2024
3 checks passed
@doug-q doug-q deleted the doug/allow-redefinition branch July 25, 2024 08:27
github-merge-queue bot pushed a commit that referenced this pull request Jul 25, 2024
🤖 I have created a release *beep* *boop*
---


## [0.7.0](v0.6.2...v0.7.0)
(2024-07-25)


### ⚠ BREAKING CHANGES

* `qubit`s are now reset on allocation

### Features

* `qubit`s are now reset on allocation, and `dirty_qubit` added
([#325](#325))
([4a9e205](4a9e205))
* Allow access to struct fields and mutation of linear ones
([#295](#295))
([6698b75](6698b75)),
closes [#293](#293)
* Allow redefinition of names in guppy modules
([#326](#326))
([314409c](314409c)),
closes [#307](#307)


### Bug Fixes

* Use correct hook for error printing inside jupyter notebooks
([#324](#324))
([bfdb003](bfdb003)),
closes [#323](#323)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redefining a function should be allowed
3 participants