feat: Add SizedIter wrapper type
#611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-koch
commented
Nov 4, 2024
Comment on lines
-264
to
+273
| @abstractmethod | ||
| def check(self, args: list[ast.expr], ty: Type) -> tuple[ast.expr, Subst]: | ||
| """Checks the return value against a given type. | ||
|
|
||
| Returns a (possibly) transformed and annotated AST node for the call. | ||
| """ | ||
| from guppylang.checker.expr_checker import check_type_against | ||
|
|
||
| expr, res_ty = self.synthesize(args) | ||
| subst, _ = check_type_against(res_ty, ty, self.node) | ||
| return expr, subst |
There was a problem hiding this comment.
Drive-by: Add a default implementation for CustomCallChecker.check that falls back to the synthesizing case if we can't make use of the incoming type information
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
=======================================
Coverage 91.64% 91.64%
=======================================
Files 60 60
Lines 6389 6443 +54
=======================================
+ Hits 5855 5905 +50
- Misses 534 538 +4 ☔ View full report in Codecov by Sentry. |
qartik
reviewed
Nov 4, 2024
|
|
qartik
approved these changes
Nov 4, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
🤖 I have created a release *beep* *boop* --- ## [0.13.0](v0.12.2...v0.13.0) (2024-11-12) ### ⚠ BREAKING CHANGES * `prelude` module renamed to `std` ### Features * add `qubit` discard/measure methods ([#580](#580)) ([242fa44](242fa44)) * Add `SizedIter` wrapper type ([#611](#611)) ([2e9da6b](2e9da6b)) * conventional results post processing ([#593](#593)) ([db96224](db96224)) * Improve compiler diagnostics ([#547](#547)) ([90d465d](90d465d)), closes [#551](#551) [#553](#553) [#586](#586) [#588](#588) [#587](#587) [#590](#590) [#600](#600) [#601](#601) [#606](#606) * restrict result tag sizes to 256 bytes ([#596](#596)) ([4e8e00f](4e8e00f)), closes [#595](#595) ### Bug Fixes * Mock guppy decorator during sphinx builds ([#622](#622)) ([1cccc04](1cccc04)) ### Documentation * Add DEVELOPMENT.md ([#584](#584)) ([1d29d39](1d29d39)) * Fix docs build ([#639](#639)) ([bd6011c](bd6011c)) ### Miscellaneous Chores * Manually set last release commit ([#643](#643)) ([b2d569b](b2d569b)) ### Code Refactoring * rename prelude to std ([#642](#642)) ([1a68e8e](1a68e8e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new wrapper type
SizedIterto the standard library that annotates an iterator with a static size hint. This will be used for example in array comprehensions to infer the size of the resulting array. The type gets erased when lowering to Hugr.Updates the
rangefunction to emit such a size hint when the range stop is given by a static number. For example the expressionrange(10)is typed asSizedIter[Range, 10]whereasrange(n + 1)is typed asRange. Currently, this is implemented via aCustomCallChecker, but in the future we could use function overloading andLiteraltypes to implement this in Guppy source:Closes #610.