From 11804606325e2aab8e912d05bf757c7aa357f684 Mon Sep 17 00:00:00 2001 From: Seyon Sivarajah Date: Fri, 22 Nov 2024 14:39:40 +0000 Subject: [PATCH] review changes and end of line fix --- .github/workflows/ci-rs.yml | 2 +- hugr-llvm/Cargo.toml | 4 ++-- hugr-llvm/src/emit.rs | 2 +- hugr-llvm/src/lib.rs | 2 +- hugr/Cargo.toml | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci-rs.yml b/.github/workflows/ci-rs.yml index ee590e4da..c7e3d8bec 100644 --- a/.github/workflows/ci-rs.yml +++ b/.github/workflows/ci-rs.yml @@ -242,7 +242,7 @@ jobs: tests-stable-llvm: needs: changes - if: ${{ ( needs.changes.outputs.llvm == 'true' && github.event_name == 'push' ) || needs.changes.outputs.override == 'true' }} + if: ${{ ( needs.changes.outputs.llvm == 'true' && github.event_name == 'push' ) || needs.changes.outputs.override == 'true' }} runs-on: ubuntu-latest name: tests hugr-llvm strategy: diff --git a/hugr-llvm/Cargo.toml b/hugr-llvm/Cargo.toml index 7d1344376..ce5cd278d 100644 --- a/hugr-llvm/Cargo.toml +++ b/hugr-llvm/Cargo.toml @@ -16,7 +16,7 @@ keywords = ["Quantum", "Quantinuum"] categories = ["compilers"] [features] -test = [ +test-utils = [ "insta", "rstest", "portgraph", @@ -50,4 +50,4 @@ serde = { workspace = true, optional = true } typetag = { workspace = true, optional = true } [dev-dependencies] -hugr-llvm = {"path" = ".", features = ["test"]} +hugr-llvm = {"path" = ".", features = ["test-utils"]} diff --git a/hugr-llvm/src/emit.rs b/hugr-llvm/src/emit.rs index 6aa4bb6a3..959838600 100644 --- a/hugr-llvm/src/emit.rs +++ b/hugr-llvm/src/emit.rs @@ -403,5 +403,5 @@ pub fn get_intrinsic<'c>( )) } -#[cfg(feature = "test")] +#[cfg(any(test, feature = "test-utils"))] pub mod test; diff --git a/hugr-llvm/src/lib.rs b/hugr-llvm/src/lib.rs index c036e05bd..98c161658 100644 --- a/hugr-llvm/src/lib.rs +++ b/hugr-llvm/src/lib.rs @@ -75,7 +75,7 @@ pub fn llvm_version() -> &'static str { panic!("No recognised llvm feature") } -#[cfg(feature = "test")] +#[cfg(any(test, feature = "test-utils"))] pub mod test; pub use custom::{CodegenExtension, CodegenExtsBuilder}; diff --git a/hugr/Cargo.toml b/hugr/Cargo.toml index a6a825b71..aa76c5859 100644 --- a/hugr/Cargo.toml +++ b/hugr/Cargo.toml @@ -26,7 +26,7 @@ extension_inference = ["hugr-core/extension_inference"] declarative = ["hugr-core/declarative"] model_unstable = ["hugr-core/model_unstable", "hugr-model"] llvm = ["hugr-llvm/llvm14-0"] -llvm-test = ["hugr-llvm/llvm14-0", "hugr-llvm/test"] +llvm-test = ["hugr-llvm/llvm14-0", "hugr-llvm/test-utils"] [dependencies] hugr-model = { path = "../hugr-model", optional = true, version = "0.14.0" }