From fd363fbb88e8517ac96d071cd8a5aefbeedc9b36 Mon Sep 17 00:00:00 2001 From: Agustin Borgna Date: Mon, 18 Mar 2024 13:14:04 +0000 Subject: [PATCH] Review suggestions --- quantinuum-hugr/src/ops/constant.rs | 2 -- quantinuum-hugr/src/types/check.rs | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/quantinuum-hugr/src/ops/constant.rs b/quantinuum-hugr/src/ops/constant.rs index de498d889..d63582aeb 100644 --- a/quantinuum-hugr/src/ops/constant.rs +++ b/quantinuum-hugr/src/ops/constant.rs @@ -21,8 +21,6 @@ pub use custom::{downcast_equal_consts, CustomConst, CustomSerialized}; #[serde(tag = "c")] pub enum Const { /// An extension constant value, that can check it is of a given [CustomType]. - /// - // Note: the extra level of tupling is to avoid https://github.com/rust-lang/rust/issues/78808 Extension { /// The custom constant value. e: ExtensionConst, diff --git a/quantinuum-hugr/src/types/check.rs b/quantinuum-hugr/src/types/check.rs index 783f1247e..d2da2a372 100644 --- a/quantinuum-hugr/src/types/check.rs +++ b/quantinuum-hugr/src/types/check.rs @@ -68,11 +68,11 @@ impl super::SumType { })?; } - for (i, (t, v)) in itertools::zip_eq(variant.iter(), val.iter()).enumerate() { + for (index, (t, v)) in itertools::zip_eq(variant.iter(), val.iter()).enumerate() { if v.const_type() != *t { Err(SumTypeError::InvalidValueType { tag, - index: i, + index, expected: t.clone(), found: v.clone(), })?;