feat(hugr-py)!: Override add rather than append + extend on all _DfBase
#1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `_DfBase`
They both take commands, just on TrackedDfg allows commands with indices in. Makes for a more consistent interface.
Allows `extend` to be defined on Dfg too.
BREAKING CHANGE:
- `TrackedDfg.append` removed, use `add` instead.
- `extend` now takes `*args` rather than an iterable.
ss2165
requested review from
croyzor and
cqc-alec
and removed request for
croyzor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1286 +/- ##
=======================================
Coverage 87.04% 87.04%
=======================================
Files 103 103
Lines 19243 19243
Branches 17073 17073
=======================================
Hits 16750 16750
Misses 1716 1716
Partials 777 777
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cqc-alec
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
Both
addandappendtake commands, butappendallows commands with indices in. We can therefore replaceappendwith anaddoverride. Makes for a more consistent interface.Allows
extendto be defined on Dfg too.BREAKING CHANGE: 1.
TrackedDfg.appendremoved, useaddinstead. 2.extendnow takes*argsrather than an iterable.END_COMMIT_OVERRIDE