-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Check python test result on required checks check #1302
Conversation
A python test failure didn't cause the required checks to fail...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at CI, shouldn't the python checks run when the workflow changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requesting changes to withdraw approval, I am suspicious because python tests are not running on this PR where the definition of successful CI is changing
I added the workflows to the change filters, so tests should run now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 107 107
Lines 19564 19566 +2
Branches 17302 17302
=======================================
+ Hits 17066 17068 +2
Misses 1714 1714
Partials 784 784
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
A python test failure didn't cause the required checks to fail...
drive-by: Add workflow files to the CI change filters, so modifications trigger the checks.