Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Check python test result on required checks check #1302

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Jul 15, 2024

A python test failure didn't cause the required checks to fail...

drive-by: Add workflow files to the CI change filters, so modifications trigger the checks.

A python test failure didn't cause the required checks to fail...
@aborgna-q aborgna-q requested a review from a team as a code owner July 15, 2024 15:46
@aborgna-q aborgna-q requested a review from doug-q July 15, 2024 15:46
Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@doug-q doug-q added this pull request to the merge queue Jul 16, 2024
@doug-q doug-q removed this pull request from the merge queue due to a manual request Jul 16, 2024
Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at CI, shouldn't the python checks run when the workflow changes?

Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes to withdraw approval, I am suspicious because python tests are not running on this PR where the definition of successful CI is changing

@aborgna-q
Copy link
Collaborator Author

I added the workflows to the change filters, so tests should run now.

@aborgna-q aborgna-q requested a review from doug-q July 16, 2024 07:54
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (cfb0674) to head (35d7abc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         107      107           
  Lines       19564    19566    +2     
  Branches    17302    17302           
=======================================
+ Hits        17066    17068    +2     
  Misses       1714     1714           
  Partials      784      784           
Flag Coverage Δ
python 91.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q aborgna-q added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 056531c Jul 16, 2024
21 checks passed
@aborgna-q aborgna-q deleted the ab/fix-ci-py branch July 16, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants