From 8081cef41bfd662f14634a3b25bac97bd689c79e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Agust=C3=ADn=20Borgna?=
 <121866228+aborgna-q@users.noreply.github.com>
Date: Thu, 7 Nov 2024 14:08:47 +0000
Subject: [PATCH] ci: Fix unsoundness notification

Looks like `continue-on-error` on a step still doesn't trigger the dependent jobs on error.

This PR ensures that the slack notification job runs when the miri checks fail by adding an `if: always()` instead.
---
 .github/workflows/unsoundness.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/unsoundness.yml b/.github/workflows/unsoundness.yml
index aa9ce1e4c..7c8fe7c30 100644
--- a/.github/workflows/unsoundness.yml
+++ b/.github/workflows/unsoundness.yml
@@ -24,7 +24,6 @@ jobs:
   miri:
     name: "Miri"
     runs-on: ubuntu-latest
-    continue-on-error: true
     steps:
       - uses: actions/checkout@v4
       - name: Install Miri
@@ -44,11 +43,12 @@ jobs:
   notify-slack:
     uses: CQCL/hugrverse-actions/.github/workflows/slack-notifier.yml@main
     needs: miri
-    if: ${{ needs.miri.result == 'failure' && ( github.event_name == 'workflow_dispatch' || github.event_name == 'push' ) }}
+    if: always() && needs.miri.result == 'failure'
     with:
       channel-id: 'C04SHCL4FKP'
       slack-message: |
-        💥 The unsoundness check for `CQCL/hugr` failed. <https://github.com/CQCL/hugr/actions/runs/${{ github.run_id }}|Please investigate>.
+        💥 The unsoundness check for `CQCL/hugr` failed.
+        <https://github.com/CQCL/hugr/actions/runs/${{ github.run_id }}|Please investigate>.
       # Rate-limit the message to once per day
       timeout-minutes: 1440
       # A repository variable used to store the last message timestamp.