Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidal regridding doesn't appear to take into account curved lat / lon #22

Closed
ashjbarnes opened this issue Oct 14, 2024 · 2 comments · Fixed by #33
Closed

Tidal regridding doesn't appear to take into account curved lat / lon #22

ashjbarnes opened this issue Oct 14, 2024 · 2 comments · Fixed by #33
Assignees

Comments

@ashjbarnes
Copy link
Collaborator

Discrepancy found in the tide and velocity/tracer boundary segments that needs to be fixed!

To reproduce:

Run through the example notebook and generate the boundary forcing files for both the regular boundaries and for the tides.

Look at the variable lon_segment_001 in both the tide and velocity / tracer segment 1 file. You'll notice that the lon_segment_001 variable, which is supposed to keep track of the longitudes along the segment, is 2D for velocity / tracers, but 1D for tides. This is because the tidal regridding functions have been borrowed and refactored from the NWA25 repository

Suggested fix: Either

  1. Refactor the regrid_tides and regrid_velocity_tracers methods to share the same regridding as regrid_tides. This would removing some from regrid_tides that's generic enough to make a regridding function. Note that the dimensions of the lon/lat variables also need to be expanded!
  2. If a refactor is too hard, need to ensure that the regrid_tides and associated encode_tidal_files_and_output function is changed to ensure that the lat/lon_segment_00x coordinates are exactly the same as the output for the velocities and tracers
@manishvenu manishvenu moved this to Todo in ToolDev Oct 16, 2024
@manishvenu
Copy link

A quick task to sneak into any PR for this could be making sure the body tides are properly setup using @gseijo's MOM_input for nwa.test.tides

@ashjbarnes
Copy link
Collaborator Author

Oops yeah that's my bad! Good spotting @gseijo I had intended to include body forcing but that didn't make it through the pipeline. Should be easy enough to put the body tide options into the setup_rundir function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants