You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Discrepancy found in the tide and velocity/tracer boundary segments that needs to be fixed!
To reproduce:
Run through the example notebook and generate the boundary forcing files for both the regular boundaries and for the tides.
Look at the variable lon_segment_001 in both the tide and velocity / tracer segment 1 file. You'll notice that the lon_segment_001 variable, which is supposed to keep track of the longitudes along the segment, is 2D for velocity / tracers, but 1D for tides. This is because the tidal regridding functions have been borrowed and refactored from the NWA25 repository
Suggested fix: Either
Refactor the regrid_tides and regrid_velocity_tracers methods to share the same regridding as regrid_tides. This would removing some from regrid_tides that's generic enough to make a regridding function. Note that the dimensions of the lon/lat variables also need to be expanded!
If a refactor is too hard, need to ensure that the regrid_tides and associated encode_tidal_files_and_output function is changed to ensure that the lat/lon_segment_00x coordinates are exactly the same as the output for the velocities and tracers
The text was updated successfully, but these errors were encountered:
Oops yeah that's my bad! Good spotting @gseijo I had intended to include body forcing but that didn't make it through the pipeline. Should be easy enough to put the body tide options into the setup_rundir function
Discrepancy found in the tide and velocity/tracer boundary segments that needs to be fixed!
To reproduce:
Run through the example notebook and generate the boundary forcing files for both the regular boundaries and for the tides.
Look at the variable
lon_segment_001
in both the tide and velocity / tracer segment 1 file. You'll notice that thelon_segment_001
variable, which is supposed to keep track of the longitudes along the segment, is 2D for velocity / tracers, but 1D for tides. This is because the tidal regridding functions have been borrowed and refactored from the NWA25 repositorySuggested fix: Either
regrid_tides
andregrid_velocity_tracers
methods to share the same regridding asregrid_tides
. This would removing some fromregrid_tides
that's generic enough to make a regridding function. Note that the dimensions of the lon/lat variables also need to be expanded!regrid_tides
and associatedencode_tidal_files_and_output
function is changed to ensure that thelat/lon_segment_00x
coordinates are exactly the same as the output for the velocities and tracersThe text was updated successfully, but these errors were encountered: