Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints for version 1.0. #45

Open
8 tasks
Tracked by #27
CSchoel opened this issue Aug 10, 2024 · 0 comments
Open
8 tasks
Tracked by #27

Add type hints for version 1.0. #45

CSchoel opened this issue Aug 10, 2024 · 0 comments
Assignees
@CSchoel
Milestone
Release nolds 1.0

Comments

@CSchoel
Copy link
Owner

CSchoel commented Aug 10, 2024 •
edited
Loading

After switching to #43, we can also abandon Python 2, which means that we can use proper type hints.

  • Switch required python version to 3.11.
  • Go through the codebase and add type hints to all public functions and classes.
    • measures.py
    • datasets.py
    • examples.py
    • test_measures.py
  • Fix all resulting type checking errors.
  • Ensure that unit tests still work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CSchoel CSchoel

Labels
None yet
Projects
None yet
Milestone
Release nolds 1.0
Development

No branches or pull requests
1 participant
@CSchoel