Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support local paths to input datasets #4

Closed
dafyddstephenson opened this issue Jul 25, 2024 · 2 comments · Fixed by #30
Closed

support local paths to input datasets #4

dafyddstephenson opened this issue Jul 25, 2024 · 2 comments · Fixed by #30
Assignees
@dafyddstephenson
Labels
enhancement New feature or request
Milestone
alpha

Comments

@dafyddstephenson
Copy link
Contributor

Currently the source attribute on Inputdataset only supports URLs to remotely hosted files, while AdditionalCode is described by a source_repo. We should support source strings that are local paths.
@dafyddstephenson dafyddstephenson added the enhancement New feature or request label Jul 25, 2024
@dafyddstephenson dafyddstephenson self-assigned this Jul 25, 2024
@TomNicholas
Copy link
Member

URLs to remotely hosted files

Github URLs? Or S3 urls? It's relevant for the idea of using cloudpathlib everywhere (see #9)

@dafyddstephenson
Copy link
Contributor Author

Not strictly either, anything pooch can fetch - #9 definitely seems relevant here though

@dafyddstephenson dafyddstephenson transferred this issue from CWorthy-ocean/C-Star_ARCHIVE Aug 8, 2024
@TomNicholas TomNicholas added this to the alpha milestone Aug 16, 2024
@dafyddstephenson dafyddstephenson changed the title support local paths to input datasets and additional code support local paths to input datasets Aug 17, 2024
This was referenced Aug 17, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dafyddstephenson dafyddstephenson

Labels
enhancement New feature or request
Projects
None yet
Milestone
alpha
Development

Successfully merging a pull request may close this issue.

Support local paths for InputDataset.source dafyddstephenson/C-Star
2 participants
@TomNicholas @dafyddstephenson