Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding robust to CoxTimeVarying fitter #544

Open
CamDavidsonPilon opened this issue Nov 22, 2018 · 4 comments
Open

Adding robust to CoxTimeVarying fitter #544

CamDavidsonPilon opened this issue Nov 22, 2018 · 4 comments
Assignees

Comments

@CamDavidsonPilon
Copy link
Owner

No description provided.

@Asieh-A-Mofrad
Copy link

Hi,

I still get 'Not ImplementedError' when setting robust= True. Just was wondering if you plan to add it to CoxTimeVarying fitter on the next release. Thanks in advance.

@CamDavidsonPilon
Copy link
Owner Author

Hi @Asieh-A-Mofrad

It's unfortunately a lot more difficult for CTV models. If you are blocked by this, I would suggest bootstrapping to determine your std. errors.

@Asieh-A-Mofrad
Copy link

Hi again,

I see, thanks a lot for your reply and your suggested solution.

All the best,
Asieh

@benslack19
Copy link

benslack19 commented Feb 23, 2024

I understand this issue has already been created for the NotImplementedError. However, according to the docstring, the default is set to True when it really is set to False. (This would also be consistent with the CPH docstring where the robust default is set to False.) I understand the implementation of the sandwich estimator is more complicated than the CoxPHFitter model. However, can this docstring for CoxTimeVaryingFitter.fit() state that robust=False and a note that there has not yet been an implementation of robust=True?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants