-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shows number of actions which are pending moderation. #698
Conversation
@Betree any concern on the approach / refresh rate ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good!
My only concern is that, while loading, we show 0
. If get(data, 'loggedInUser.actions_pending_moderation')
is undefined, we should not show anything. But this one can be part of a later PR if you don't have the time to iterate on it.
* Uses HD thumbnail for opengraph when available. (#696) Co-authored-by: Benjamin Piouffle <[email protected]> * chore(deps): [security] bump npm-user-validate from 1.0.0 to 1.0.1 (#697) Bumps [npm-user-validate](https://github.com/npm/npm-user-validate) from 1.0.0 to 1.0.1. **This update includes a security fix.** - [Release notes](https://github.com/npm/npm-user-validate/releases) - [Commits](npm/npm-user-validate@v1.0.0...v1.0.1) Signed-off-by: dependabot-preview[bot] <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * set required reputation to add video to 75 (#701) * Shows number of actions which are pending moderation. (#698) * Shows number of actions which are pending moderation. * Format code. * Merge mistake on format. * Fixes margin of menu tag. * enhancement(queries/ModerationCount): Add id to the fetch Co-authored-by: Benjamin Piouffle <[email protected]> Co-authored-by: Abou Konaté <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
I saw that you took care of hiding the badge instead of showing 0, great ! |
Indeed! Sorry for not pinging you about the change, I did it a bit in a hurry ^^ |
NP :) I saw this before considering working on that ! |
Fixes CaptainFact/captain-fact#95.