Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows number of actions which are pending moderation. #698

Merged
merged 5 commits into from
Nov 14, 2020

Conversation

steelstyle
Copy link
Contributor

@steelstyle steelstyle requested a review from Betree October 23, 2020 16:32
@steelstyle
Copy link
Contributor Author

@Betree any concern on the approach / refresh rate ?

Copy link
Member

@Betree Betree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good!

My only concern is that, while loading, we show 0. If get(data, 'loggedInUser.actions_pending_moderation') is undefined, we should not show anything. But this one can be part of a later PR if you don't have the time to iterate on it.

@Betree Betree merged commit 0f20810 into staging Nov 14, 2020
@Betree Betree deleted the show-pending-moderation branch November 14, 2020 17:21
Betree added a commit that referenced this pull request Nov 14, 2020
* Uses HD thumbnail for opengraph when available. (#696)

Co-authored-by: Benjamin Piouffle <[email protected]>

* chore(deps): [security] bump npm-user-validate from 1.0.0 to 1.0.1 (#697)

Bumps [npm-user-validate](https://github.com/npm/npm-user-validate) from 1.0.0 to 1.0.1. **This update includes a security fix.**
- [Release notes](https://github.com/npm/npm-user-validate/releases)
- [Commits](npm/npm-user-validate@v1.0.0...v1.0.1)

Signed-off-by: dependabot-preview[bot] <[email protected]>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* set required reputation to add video to 75 (#701)

* Shows number of actions which are pending moderation. (#698)

* Shows number of actions which are pending moderation.

* Format code.

* Merge mistake on format.

* Fixes margin of menu tag.

* enhancement(queries/ModerationCount): Add id to the fetch

Co-authored-by: Benjamin Piouffle <[email protected]>

Co-authored-by: Abou Konaté <[email protected]>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@steelstyle
Copy link
Contributor Author

steelstyle commented Nov 19, 2020

I saw that you took care of hiding the badge instead of showing 0, great !
Also I will keep adding "id" in mind for the future.

@Betree
Copy link
Member

Betree commented Nov 20, 2020

Indeed! Sorry for not pinging you about the change, I did it a bit in a hurry ^^

@steelstyle
Copy link
Contributor Author

NP :) I saw this before considering working on that !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show unread moderations entries count on sidebar
2 participants