Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Tx Id from submitTx function #174

Closed
rumourscape opened this issue Feb 12, 2022 · 1 comment
Closed

Return Tx Id from submitTx function #174

rumourscape opened this issue Feb 12, 2022 · 1 comment
Labels
help welcomed Good for newcomers server Issues which regard the server

Comments

@rumourscape
Copy link

Describe your idea, in simple words.

It would be helpful if the submitTx function returned the tx id upon successful submission of the transaction. Currently it returns nothing.

Why is it a good idea?

Most similar submitTx functions in other services(like submit-api) returns the tx hash. It also makes logging submitted txs easier.

Are you willing to work on it yourself?

No. But I think it would be an easy thing for you to add.
@KtorZ KtorZ added enhancement help welcomed Good for newcomers server Issues which regard the server labels Feb 12, 2022
@KtorZ KtorZ mentioned this issue Feb 13, 2022
Merged
@KtorZ
Copy link
Member

KtorZ commented Feb 13, 2022

Fixed in #176.

Thanks for the suggestion :)

@KtorZ KtorZ closed this as completed Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help welcomed Good for newcomers server Issues which regard the server
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KtorZ @rumourscape