Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dependencies peer dependencies #415

Open
trajano opened this issue Jun 25, 2021 · 0 comments
Open

Make dependencies peer dependencies #415

trajano opened this issue Jun 25, 2021 · 0 comments

Comments

@trajano
Copy link

trajano commented Jun 25, 2021

Expected Behavior

As this is more of a extension to a project rather than a standalone. it is better to have things as peer dependencies.

Current Behavior

dependencies are in package.json

Possible Solution

dependencies should be copied to peerDependencies and devDependences

Steps to Reproduce (for bugs)

n/a

Context

I recently encountered this Invariant Violation: Tried to register two views with the same name RNCWebview due to different versions of react-native-webview because due to my situation, I have to use the older version of this module and expo updated to v11.

Your Environment

  • Version used:
  • Browser Name and version:
  • Operating System and version (desktop or mobile):
  • Link to your project:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trajano