Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code format: use dotnet format, add .editorconfig, add to CI #101

Open
nietras opened this issue Apr 16, 2024 · 2 comments
Open

code format: use dotnet format, add .editorconfig, add to CI #101

nietras opened this issue Apr 16, 2024 · 2 comments

Comments

@nietras
Copy link
Contributor

nietras commented Apr 16, 2024

It would be nice if the code followed "normal" C# formatting and simply used "dotnet format" as part of workflow and CI. Since I use format on save I had to do quite a bit of jumping back and forth and disable it when doing the #100 PR.

I could potentially adopt practices and workflows from https://github.com/nietras/Sep here if there was an interest in that.

@CarlVerret
Copy link
Owner

I totally agree. I did a lot of changes to the code formating when I merged our project into .net 7 std library. I should have did the same to this lib a while ago.
I'm not really familiar about how to add the dotnet format in the CI, I'd be glad to learn about it if you've got any info about that. In the meantime, i just merged a new version that includes an editorconfig file !

@nietras
Copy link
Contributor Author

nietras commented Apr 20, 2024

great, I believe it is best if editorconfig is in root of project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants