Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check performance diff with manual hoisting of vectors #93

Open
CarlVerret opened this issue Oct 22, 2021 · 0 comments
Open

Check performance diff with manual hoisting of vectors #93

CarlVerret opened this issue Oct 22, 2021 · 0 comments

Comments

@CarlVerret
Copy link
Owner

Same here, hoist manually.

I have to admit that the code doesn't look as nice then, but from some previous work (in other parsers / validators) there was always a big enough boost to justify that change. But please measure it.

Basically it's similar to this example, compare the output from M1, and M2. You can see the load of the constant inside the loop in M1, but hoisted (manually) above the loop in M2.

Originally posted by @gfoidl in #91 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant