Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliable and more powerful unit testing. #15

Closed
portlek opened this issue Jul 17, 2020 · 2 comments · Fixed by #24
Closed

Reliable and more powerful unit testing. #15

portlek opened this issue Jul 17, 2020 · 2 comments · Fixed by #24

Comments

@portlek
Copy link
Contributor

portlek commented Jul 17, 2020

ATM, the testing is not safe so much. We should add official unit test with jupiter and it should work when we build the project.

<dependency>
    <groupId>org.junit.jupiter</groupId>
    <artifactId>junit-jupiter</artifactId>
    <version>5.6.2</version>
    <scope>test</scope>
</dependency>

Also, need a plugin;

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-surefire-plugin</artifactId>
    <version>2.22.2</version>
</plugin>

for automatic tests when the project is building.

@Carleslc
Copy link
Owner

You're right. Current tests are not unit tests, they were created for example of usage of the library. However, unit tests with JUnit are preferable for testing.

@portlek
Copy link
Contributor Author

portlek commented Jul 17, 2020

You're right. Current tests are not unit tests, they were created for example of usage of the library. However, unit tests with JUnit are preferable for testing.

junit = jupiter :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants