Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy pinned to 1.23.5? #339

Closed
qchempku2017 opened this issue Feb 23, 2023 · 1 comment
Closed

Numpy pinned to 1.23.5? #339

qchempku2017 opened this issue Feb 23, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@qchempku2017
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Numpy dependency for smol has not been upgraded for a while. @lbluque could you please explain what is happening with newer versions of numpy?
@qchempku2017 qchempku2017 added the enhancement New feature or request label Feb 23, 2023
@lbluque
Copy link
Collaborator

lbluque commented Feb 23, 2023

The issue is with emmet a dependency of pymatgen:
materialsproject/emmet#624

It seems its been fixed so I will update numpy now.

By the way the actually dependency versions are the ones listed in setup.cfg not the ones listed in requirements.txt (those are used for CI purposes only)

@lbluque lbluque closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lbluque @qchempku2017