You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While setting up performance tests for dynamicScreenSpaceError (needed for #4196), I discovered that the parameters I passed into the Cesium3DTileset constructor options were doing nothing.
On inspecting the code, the options like dynamicScreenSpaceErrorFactor are ignored and just hard-coded as 4.
The fix is to just make sure the option gets propagated with defaultValue(option, default) as usual.
Note that this is distinct from #6143 which is about one of these parameters not propagated correctly in the 3D Tiles Inspector.
The text was updated successfully, but these errors were encountered:
Yes, I believe the fact that the dynamicScreenSpaceErrorFactor option was hardcoded led to the constructor option not doing anything because it wasn't taking any input.
While setting up performance tests for
dynamicScreenSpaceError
(needed for #4196), I discovered that the parameters I passed into theCesium3DTileset
constructor options were doing nothing.On inspecting the code, the options like
dynamicScreenSpaceErrorFactor
are ignored and just hard-coded as 4.The fix is to just make sure the option gets propagated with
defaultValue(option, default)
as usual.Note that this is distinct from #6143 which is about one of these parameters not propagated correctly in the 3D Tiles Inspector.
The text was updated successfully, but these errors were encountered: