Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cesium3DTileset constructor ignores some dynamicScreenSpaceError options #11677

Closed
ptrgags opened this issue Dec 5, 2023 · 2 comments · Fixed by #11718
Closed

Cesium3DTileset constructor ignores some dynamicScreenSpaceError options #11677

ptrgags opened this issue Dec 5, 2023 · 2 comments · Fixed by #11718

Comments

@ptrgags
Copy link
Contributor

ptrgags commented Dec 5, 2023

While setting up performance tests for dynamicScreenSpaceError (needed for #4196), I discovered that the parameters I passed into the Cesium3DTileset constructor options were doing nothing.

On inspecting the code, the options like dynamicScreenSpaceErrorFactor are ignored and just hard-coded as 4.

The fix is to just make sure the option gets propagated with defaultValue(option, default) as usual.

Note that this is distinct from #6143 which is about one of these parameters not propagated correctly in the 3D Tiles Inspector.

@ptrgags
Copy link
Contributor Author

ptrgags commented Dec 6, 2023

Also such an update would be a good time to improve the documentation for these parameters. see #4196 (comment) for some initial thoughts.

@Saicbmm
Copy link

Saicbmm commented Dec 23, 2023

Yes, I believe the fact that the dynamicScreenSpaceErrorFactor option was hardcoded led to the constructor option not doing anything because it wasn't taking any input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants