Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better KML Network Link Error Handling #5921

Closed
hpinkos opened this issue Oct 20, 2017 · 1 comment
Closed

Better KML Network Link Error Handling #5921

hpinkos opened this issue Oct 20, 2017 · 1 comment

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Oct 20, 2017

In #5871 we added a catch when a network link fails. This makes it impossible to detect and handle errors programmatically. We might want to consider adding support for a callback when a network link fails.

@thw0rted
Copy link
Contributor

It looks like failed network links already raise the errorEvent, which is good, except for this one overlooked case, which is an easy fix. Compare with L2427 -- basically, any loadBlob.otherwise() should be raising the error event and the linked PR didn't follow that pattern.

This bit me today. I loaded a file (from a "good" server) that includes a NetworkLink on a "bad" server, with a self-signed cert I hadn't manually added an exception for. The initial (KML) load was fine, so the error handler I'd attached to the promise returned by src.load() didn't fire, but the NetworkLink load (which of course fires asynchronously) didn't work. Anyway, easy one-line fix and I think this can be closed. I'd do it myself but I never got my dang management to sign off on the CLA. (I'll bug them again, I swear!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants