Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glTF 2.0 Model Test Failure #7073

Closed
hpinkos opened this issue Sep 26, 2018 · 3 comments
Closed

glTF 2.0 Model Test Failure #7073

hpinkos opened this issue Sep 26, 2018 · 3 comments

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Sep 26, 2018

Both @mramato and I are seeing this test failure. Can someone please look at this before the release on Monday? @lilleyse @likangning93 @ggetz @OmarShehata

loads a glTF 2.0 model
     Scene/Model
     Expected to render [169,3,3,255], but actually rendered [170,6,6,255].
    at <Jasmine>
    at Specs/Scene/ModelSpec.js:948:27
    at Promise.then (Source/ThirdParty/when.js:196:34)
    at Source/ThirdParty/when.js:297:13
    at processQueue (Source/ThirdParty/when.js:647:4)
@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 26, 2018

@OmarShehata could you please take a first look? Potentially a trivial change to adjust the test if we deem nothing broke.

@likangning93
Copy link
Contributor

Wonder if this is related to #6877

@lilleyse
Copy link
Contributor

Yeah I think it's just a matter of the test being too strict, since the rendered color may vary between systems. Usually checking that the color is within some loose range is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants