Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning for fetchImage in 1.57 #7630

Closed
OmarShehata opened this issue Mar 11, 2019 · 3 comments
Closed

Remove deprecation warning for fetchImage in 1.57 #7630

OmarShehata opened this issue Mar 11, 2019 · 3 comments

Comments

@OmarShehata
Copy link
Contributor

OmarShehata commented Mar 11, 2019

The createImageBitmap PR #7579 changed the parameters for Resource.fetchImage and added a deprecation warning:

https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Core/Resource.js#L900

Which should be removed in 1.57.

Can we add the deprecation label? @hpinkos

It also looks like Resource.addQueryParameters deprecation warning was supposed to be removed in 1.45:

https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Core/Resource.js#L612

@lilleyse lilleyse changed the title Remove deprecation warning for fetchImage in 1.56 Remove deprecation warning for fetchImage in 1.57 Apr 1, 2019
@lilleyse
Copy link
Contributor

lilleyse commented Apr 1, 2019

I changed the title and description to 1.57 since the PR that deprecated the behavior was merged this month and needs at least one month of being deprecated.

Though I opened #7695 to remove addQueryParameters and addTemplateValues.

@tfili
Copy link
Contributor

tfili commented Apr 29, 2019

@OmarShehata Can you remove the deprecation warning for the next release?

@tfili
Copy link
Contributor

tfili commented May 1, 2019

Fixed in #7799

@tfili tfili closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants