Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cesium3D Tilesets credits broken #7876

Closed
mramato opened this issue May 29, 2019 · 1 comment · Fixed by #7877
Closed

Cesium3D Tilesets credits broken #7876

mramato opened this issue May 29, 2019 · 1 comment · Fixed by #7877

Comments

@mramato
Copy link
Contributor

mramato commented May 29, 2019

Cesium3DTileset credits are not properly showing up in the Data attribution panel. git bisect points to 43c0141 as the first bad commit.

I'm not sure if the problem is where being/end is being called in the linked commit or if the problem is that the credits are in the postPassesUpdate function of Cesium3DTileset (and happening outside the begin end. ideas?

CC @loshjawrence @lilleyse since this was in the streaming PR it would be good if one of you could take a look; but if you absolutely can't I can try to dig in. We need this fixed ASAP.

@lilleyse
Copy link
Contributor

Opened #7877

I'm not sure if the problem is where being/end is being called in the linked commit or if the problem is that the credits are in the postPassesUpdate function of Cesium3DTileset (and happening outside the begin end. ideas?

Yes that was the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants