-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PolylineCollection Test Failure #7892
Comments
@lilleyse are you seeing this test failure? I'm seeing it in both Chrome and Firefox. I haven't checked the other browsers yet. |
The test fails at this commit between 1.37 and 1.38. Not sure why it's suddenly failing now. I might have to pass this off to someone else more familiar with the polyline collection. |
Doesn't that change fix what the test is supposed to be testing for? |
Maybe? It doesn't seem like the test should fail though. If you change |
Well, if it's failing in previous releases, it doesn't have to hold up this release. Something must have changed outside of our code base, like a browser issue. It definitely didn't fail when I released 1.55, but I just checked out that tag and it fails now. |
I'm going to label this |
Probably not by either of us. Ok to push. |
I changed the priority to |
Ran into this while doing the 1.61 release. It passes fine in Chrome, but errors in Edge and Firefox. |
I'm seeing this failure in master (afff7a4) right now on Chrome, Windows. Is it still inconsistent for other people? These tests fail in Chrome for me:
The first one also fails in Firefox for me, but the other two are fine there. I can't get the Jasmine page to render in Edge at all, it just gives a totally useless |
I'm seeing this failure in Firefox only while doing the 1.73 release. My Firefox is using my Intel GPU while Chrome is using the NVidia one, so that could be the cause rather than the browser. In any case, I'm not going to let this hold up the release. |
Sorry it's not Long story short, in Firefox on my system at least, |
That's interesting, Tim, because my situation is exactly backwards: Firefox on NVidia, Chrome on Intel. So maybe the last two bullets in my previous post are particular to Intel GPUs? |
Still failing |
I don't think this has come up during releases for the past while and I can't reproduce on an Intel mac in Chrome or Firefox. I'll close this for now. |
@ebogo1 I finally got a chance to test again and I still get this error. Full output of
That's Chrome latest, Win10, on Intel HD 630 (iGPU). I ran again in Firefox latest, on NVidia 1060 (dGPU):
(Sorry about the formatting, the Firefox webdriver doesn't seem to be as well supported as the Chrome one.) As stated in previous comments, it looks like the subject failures only happen on Windows, when using an Intel GPU. Please re-open and test on a Windows machine. Also: the "render loop" test failures wouldn't be caught by Travis because it runs with |
In case it helps: I spent at least 15 minutes faffing around with the "--include" CLI option trying to get it to work before I remembered I can just change the spec I'm interested in to use TL;DR: change |
http://localhost:8080/Specs/SpecRunner.html?spec=Scene%2FPolylineCollection%20renders%20more%20than%2064K%20vertices%20of%20different%20polylines
The text was updated successfully, but these errors were encountered: