Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground primitive artifact on iPad #8288

Open
OmarShehata opened this issue Oct 15, 2019 · 3 comments
Open

Ground primitive artifact on iPad #8288

OmarShehata opened this issue Oct 15, 2019 · 3 comments

Comments

@OmarShehata
Copy link
Contributor

OmarShehata commented Oct 15, 2019

Sandcastle link. This works fine on desktop, and mostly fine on iPad:

correct

Until you zoom in a bit on iPad, you can see a seam very similar to the one in #8205 that moves with the camera that will cut out pieces of the polygon:

incorrect

I believe it's related to #8205 because I can see the same seam across the 3D Tileset, but using that branch the seam is fixed on the 3D Tileset but remains on the ground polygons.

@lilleyse
Copy link
Contributor

How many frustums are being drawn in that view. It might not be #8205 if it's just one.

@likangning93 might have a better idea.

@lilleyse
Copy link
Contributor

Oh except this is iPad which may not support log depth, so there are probably multiple frustums.

@OmarShehata
Copy link
Contributor Author

Yes, I suspect there's multiple frustums because iPad doesn't support log depth. Although I can't reproduce the issue on desktop by turning off log depth. I updated the Sandcastle to turn off log depth and include the inspector. You can see it's using 2 frustums:

two_frustums

And at that camera distance that "shreds" the polygon, if you show the frustum geometry and rotate around, you can see it's when the frustum plane intersects that building:

frustum_intersect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants