From b100fb67a252ef8c85931111cd1da040c223417c Mon Sep 17 00:00:00 2001 From: Ian Lilley Date: Wed, 29 Jan 2020 20:27:46 -0500 Subject: [PATCH 1/3] fixed plane geometry crash when the normal is same direction as geodetic surface normal --- Source/DataSources/PlaneGeometryUpdater.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Source/DataSources/PlaneGeometryUpdater.js b/Source/DataSources/PlaneGeometryUpdater.js index 2524e6005dfa..d3bf65badfb0 100644 --- a/Source/DataSources/PlaneGeometryUpdater.js +++ b/Source/DataSources/PlaneGeometryUpdater.js @@ -240,6 +240,9 @@ import Property from './Property.js'; var up = ellipsoid.geodeticSurfaceNormal(translation, scratchAxis2); if (CesiumMath.equalsEpsilon(Math.abs(Cartesian3.dot(up, transformedNormal)), 1.0, CesiumMath.EPSILON8)) { up = Cartesian3.clone(Cartesian3.UNIT_Z, up); + if (CesiumMath.equalsEpsilon(Math.abs(Cartesian3.dot(up, transformedNormal)), 1.0, CesiumMath.EPSILON8)) { + up = Cartesian3.clone(Cartesian3.UNIT_X, up); + } } var left = Cartesian3.cross(up, transformedNormal, scratchAxis); From 9a09c5acd552bc16149fd7e3fd715dd87086d274 Mon Sep 17 00:00:00 2001 From: Ian Lilley Date: Wed, 29 Jan 2020 21:11:19 -0500 Subject: [PATCH 2/3] updated changes.md --- CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 1e2b2cc0b088..917a93219f8e 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -47,7 +47,7 @@ Change Log * Fixed a crash that could occur when an entity was deleted while the corresponding `Primitive` was being created asynchronously. [#8569](https://github.com/AnalyticalGraphicsInc/cesium/pull/8569) * Fixed a crash when calling `camera.lookAt` with the origin as the target. This could happen when looking at a tileset with the origin as its center. [#8571](https://github.com/AnalyticalGraphicsInc/cesium/pull/8571) * Fixed a bug where `camera.viewBoundingSphere` was modifying the `offset` parameter [#8438](https://github.com/AnalyticalGraphicsInc/cesium/pull/8438) - +* Fixed a crash when creating a plane with both position and normal on the Z-axis. [#8576](https://github.com/AnalyticalGraphicsInc/cesium/pull/8576) ### 1.65.0 - 2020-01-06 ##### Breaking Changes :mega: From 109f85530d5d859b097e4bc2523f3ec9da5a44be Mon Sep 17 00:00:00 2001 From: Ian Lilley Date: Wed, 29 Jan 2020 21:12:23 -0500 Subject: [PATCH 3/3] added enter --- CHANGES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.md b/CHANGES.md index 917a93219f8e..f0651e070b9f 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -48,6 +48,7 @@ Change Log * Fixed a crash when calling `camera.lookAt` with the origin as the target. This could happen when looking at a tileset with the origin as its center. [#8571](https://github.com/AnalyticalGraphicsInc/cesium/pull/8571) * Fixed a bug where `camera.viewBoundingSphere` was modifying the `offset` parameter [#8438](https://github.com/AnalyticalGraphicsInc/cesium/pull/8438) * Fixed a crash when creating a plane with both position and normal on the Z-axis. [#8576](https://github.com/AnalyticalGraphicsInc/cesium/pull/8576) + ### 1.65.0 - 2020-01-06 ##### Breaking Changes :mega: