Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicates types in forest. #1492

Closed
13 tasks done
lemmih opened this issue Mar 22, 2022 · 1 comment · Fixed by #1495
Closed
13 tasks done

Remove duplicates types in forest. #1492

lemmih opened this issue Mar 22, 2022 · 1 comment · Fixed by #1495
Assignees
Labels
Maintenance Priority: 3 - Medium Nice-to-have, does not impede core functionality Type: Enhancement

Comments

@lemmih
Copy link
Contributor

lemmih commented Mar 22, 2022

Issue summary

  • These types were copied to fvm_shared and should be removed from forest:
    • encoding/src/bytes.rs: BytesDe
    • encoding/src/bytes.rs: Byte32De
    • encoding/src/bytes.rs: BytesSer
    • types/src/sector/mod.rs: SectorSize
    • types/src/sector/mod.rs: SectorID
    • types/src/sector/registered_proof.rs: RegisteredPoStProof
    • types/src/sector/registered_proof.rs: RegisteredSealProof
    • types/src/sector/registered_proof.rs: RegisteredAggregateProof
    • types/src/sector/post.rs: SectorInfo
    • types/src/sector/post.rs: PoStProof
    • types/src/sector/post.rs: WinningPoStVerifyInfo
    • types/src/sector/post.rs: WinningPoStVerifyInfo
    • types/src/sector/post.rs: OnChainWindowPoStVerifyInfo

Other information and links

@lemmih lemmih added the Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee label Mar 22, 2022
@lemmih lemmih added Priority: 3 - Medium Nice-to-have, does not impede core functionality Type: Enhancement Maintenance and removed Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee labels Mar 22, 2022
@LesnyRumcajs
Copy link
Member

There are some spaghetti dependencies that need to be taken care of first, need to get rid of Forest's HAMT and AMT in favour of FVM ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Priority: 3 - Medium Nice-to-have, does not impede core functionality Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants