Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Kademlia workaround once rust-libp2p is updated #4602

Closed
LesnyRumcajs opened this issue Jul 31, 2024 · 0 comments · Fixed by #4637
Closed

Revert Kademlia workaround once rust-libp2p is updated #4602

LesnyRumcajs opened this issue Jul 31, 2024 · 0 comments · Fixed by #4637
Labels
Priority: 3 - Medium Nice-to-have, does not impede core functionality Type: Enhancement

Comments

@LesnyRumcajs
Copy link
Member

Issue summary

Confirmed that the issue has been fixed in rust-libp2p, see libp2p/rust-libp2p#5269
We just need to upgrade libp2p-kad once it's released and revert #4580

As outlined in #4576 (comment), the workaround exists because relevant crates were not yet released.

Given the releases are pretty seldom in the rust-libp2p world, we shouldn't expect it to happen any time soon and can check that only periodically.

Other information and links
@LesnyRumcajs LesnyRumcajs mentioned this issue Jul 31, 2024
Closed
@lemmih lemmih added Priority: 3 - Medium Nice-to-have, does not impede core functionality Status: BLOCKED Type: Enhancement labels Aug 2, 2024
@hanabi1224 hanabi1224 mentioned this issue Aug 6, 2024
Merged
4 tasks
@hanabi1224 hanabi1224 linked a pull request Aug 12, 2024 that will close this issue
chore(deps): upgrade libp2p #4637
Merged
4 tasks
@hanabi1224 hanabi1224 mentioned this issue Aug 12, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: 3 - Medium Nice-to-have, does not impede core functionality Type: Enhancement
Projects
Forest Backlog 🌲
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): upgrade libp2p ChainSafe/forest
3 participants
@lemmih @hanabi1224 @LesnyRumcajs