Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): add String() string methods on complex types logged #1945

Open
qdm12 opened this issue Oct 30, 2021 · 0 comments
Open

chore(logs): add String() string methods on complex types logged #1945

qdm12 opened this issue Oct 30, 2021 · 0 comments

Comments

@qdm12
Copy link
Contributor

qdm12 commented Oct 30, 2021

Issue summary

When reviewing most of the log usage in #1928 I noticed several structures did not have an associated .String() string method, which makes the log ugly and bit pointless (e.g. who cares about a pointer address).

The following structures were identified as logged out, complex enough and without a String method:

  • dot.LogConfig
  • dot.NetworkConfig
  • dot.Config
  • dot.RPCConfig
  • types.GrandpaForcedChange
  • GrandpaMessage
  • CommitMessage
  • VoteMessage
  • runtime.Context
  • PublicKey (mirror Hex with String)
  • babe.Slot done in chore(logging): replace log15 library #1928
  • dot.LogConfig
  • types.GrandpaScheduledChange
  • scale.VaryingDataType
  • types.EpochData
  • types.GrandpaForcedChange
  • types.ConfigData
  • types.Block
  • types.Header
  • cfg.Core.Roles
  • lib/crypto.PublicKey
  • crypto.Keypair
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants