Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the EndBlockHash from BlockRequestMessage #2883

Closed
EclesioMeloJunior opened this issue Oct 10, 2022 · 2 comments · Fixed by #2977
Closed

Remove the EndBlockHash from BlockRequestMessage #2883

EclesioMeloJunior opened this issue Oct 10, 2022 · 2 comments · Fixed by #2977
Assignees
@EclesioMeloJunior

Comments

@EclesioMeloJunior
Copy link
Member

Issue summary

  • remove the EndBlockHash from BlockRequestMessage at dot/network/message.go

Other information and links
@EclesioMeloJunior EclesioMeloJunior mentioned this issue Nov 11, 2022
Closed
@EclesioMeloJunior
Copy link
Member Author

I am noticing the following trace log very often:

TRACE    host 12D3KooWNPVTn7SZ8p5uM8nUjMZSFoA9rkUxzHtWRt5Q2tnwgQE6 received message from peer 12D3KooWDpJ7As7BWAwRMfu1VU2WCqNjvq387JEYKDBj4kx6nXTN: BlockRequestMessage RequestedData=19 StartingBlock={[190 129 209 122 153 242 88 33 207 20 204 133 117 48 159 149 191 11 27 196 184 73 212 114 129 145 35 164 119 106 183 226]} EndBlockHash=0x0000000000000000000000000000000000000000000000000000000000000000 Direction=1 Max=1	inbound.go:L43	pkg=network
DEBUG    handling BlockRequestMessage with direction descending from start block with hash 0xbe81d17a99f25821cf14cc8575309f95bf0b1bc4b849d472819123a4776ab7e2 to end block with hash 0xbe81d17a99f25821cf14cc8575309f95bf0b1bc4b849d472819123a4776ab7e2	message.go:L212	pkg=sync
TRACE    failed to read from stream id 12D3KooWDp-1-10 of peer 12D3KooWDpJ7As7BWAwRMfu1VU2WCqNjvq387JEYKDBj4kx6nXTN using protocol /dot/sync/2: failed to read length: EOF	inbound.go:L25	pkg=network

I believe there is a relation with this field being removed from substrate

@EclesioMeloJunior EclesioMeloJunior self-assigned this Nov 21, 2022
@EclesioMeloJunior EclesioMeloJunior mentioned this issue Nov 25, 2022
Merged
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EclesioMeloJunior EclesioMeloJunior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(dot/sync): Remove the EndBlockHash from BlockRequestMessage ChainSafe/gossamer
2 participants
@danforbes @EclesioMeloJunior