Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CanSecond message process logic to support elastic scaling #4329

Open
1 task
Tracked by #3820
axaysagathiya opened this issue Nov 16, 2024 · 0 comments
Open
1 task
Tracked by #3820
Labels
S-subsystems-backing issues related to polkadot host backing subsystem functionality.

Comments

@axaysagathiya
Copy link
Contributor

axaysagathiya commented Nov 16, 2024

Issue summary

Now we have a prospective-parachain subsystem skeleton, So use overseer messages declared in that subsystem and remove the old/unnecessary types.

Remove all usage of ProspectiveParachainMode, perLeaf field of CandidateBacking struct.

Logic of this function written in the context of fragment tree, need to remove this code. after removing this code we just need to perform seconding sanity check to find if it is possible to second a candidate.

update logic of seconding sanity check:

  • now as we don't want to use prospective parachain mode anymore. instead of iterating over perLeaf, iterate over leaves in the implicit view.
  • get hypothetical membership of the candidates from prospective parachain[res: candidate and it's hypothetical membership(list of leaves where the candidate could be added)]
  • for each active leaf, check if they are present in the hypothetical membership. if present it's possible to second the candidate at that leaf.
  • return the list possible of active leaves where candidate can be seconded.(return type changed)

If we don't find any leaf at which we can second the candidate, it is impossible to second the candidate

TODO:

  • make sure we do not have any comment or code related to fragment tree as we want to update the code to use fragment chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-subsystems-backing issues related to polkadot host backing subsystem functionality.
Projects
None yet
Development

No branches or pull requests

1 participant