Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple failed test runs on unstable branch #6040

Closed
nflaig opened this issue Oct 17, 2023 · 5 comments
Closed

Multiple failed test runs on unstable branch #6040

nflaig opened this issue Oct 17, 2023 · 5 comments
Labels
meta-bug Issues that identify a bug and require a fix. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.

Comments

@nflaig
Copy link
Member

nflaig commented Oct 17, 2023

Describe the bug

E2E are unstable and fail randomly due to different reasons

https://github.com/ChainSafe/lodestar/actions/runs/6544810359/job/17772581931#step:6:4013

@lodestar/beacon-node: ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
@lodestar/beacon-node:  FAIL  test/e2e/network/reqrespEncode.test.ts > reqresp encoder > assert correct handler switch between metadata v2 and v1
@lodestar/beacon-node:  Test Files  1 failed | 15 passed | 7 skipped (23)
@lodestar/beacon-node: CodeError: Transport (@libp2p/tcp) could not listen on any available address
@lodestar/beacon-node:       Tests  1 failed | 93 passed | 84 skipped (178)
@lodestar/beacon-node:    Start at  09:09:32

https://github.com/ChainSafe/lodestar/actions/runs/6517197158/job/17701469723#step:6:4037

@lodestar/beacon-node: ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯
@lodestar/beacon-node:  FAIL  test/e2e/api/impl/lightclient/endpoint.test.ts > lightclient api > getOptimisticUpdate()
@lodestar/beacon-node:  Test Files  1 failed | 15 passed | 7 skipped (23)
@lodestar/beacon-node: AssertionError: expected 3 to be 4 // Object.is equality

https://github.com/ChainSafe/lodestar/actions/runs/6517197158/job/17701499293#step:6:1483

@lodestar/beacon-node: Segmentation fault (core dumped)
@lodestar/beacon-node: @lodestar/beacon-node: error Command failed with exit code 139.

Expected behavior

No failures, stable tests

Steps to reproduce

Run E2E on unstable branch

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

unstable (c06f4e5)

@nflaig nflaig added the meta-bug Issues that identify a bug and require a fix. label Oct 17, 2023
@nflaig nflaig changed the title Multiple failed test runs on unstable Multiple failed test runs on unstable branch Oct 17, 2023
@philknows philknows added the scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. label Oct 17, 2023
@nflaig
Copy link
Member Author

nflaig commented Oct 24, 2023

Tests are really flaky right now

  • unit tests fail almost 50% of the time with @lodestar/beacon-node: Segmentation fault (core dumped) (vitest related?)
  • spec tests consistently run into timeouts (maybe related to running them in parallel)
  • sim tests fail due to timeout (this was always an issue)
  • e2e sometimes fail due to invalid assertions (seems to happen since we switched to vitest)

@wemeetagain
Copy link
Member

Maybe we should consider setting up a server to run a self-hosted runner?
That should get more consistent test results and have a better debugging story, eg for collecting core dumps, logs, etc.

@nflaig
Copy link
Member Author

nflaig commented Oct 25, 2023

Maybe we should consider setting up a server to run a self-hosted runner?

That could definitely improve the situation as it is quite noticeable that the CI get less stable if there are multiple concurrent runs

@Aminechakr
Copy link

If we can get some metrics about the runner jobs, on how much does it take in terms of cpu/mem during the multiple executions(maybe disk i/o as well if there's any disk writes), it will certainly help on accurately sizing the self-hosted runner.

@nflaig
Copy link
Member Author

nflaig commented Jan 26, 2024

Closed in favor of #6358

@nflaig nflaig closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix. scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Development

No branches or pull requests

4 participants