Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update references to consensus spec #6127

Closed
nflaig opened this issue Nov 25, 2023 · 2 comments · Fixed by #6704
Closed

Update references to consensus spec #6127

nflaig opened this issue Nov 25, 2023 · 2 comments · Fixed by #6704
Assignees
Labels
prio-medium Resolve this some time soon (tm). scope-documentation All issues related to the Lodestar documentation. spec-deneb 🐡 Issues targeting the Deneb spec version

Comments

@nflaig
Copy link
Member

nflaig commented Nov 25, 2023

It might be worth updating the consensus-specs link to so that they both point to their respective master branches.

I don't think it good to point to master branch unless there are no tagged versions. We have a bunch of references to the consensus spec, e.g. in the README

[![Ethereum Consensus Spec v1.1.10](https://img.shields.io/badge/ETH%20consensus--spec-1.1.10-blue)](https://github.com/ethereum/consensus-specs/releases/tag/v1.1.10)

All those references are kinda outdated as we already test against v1.4.0 (which has no major release yet) but could at least update to v1.3.0

specVersion: "v1.4.0-beta.2-hotfix",

Originally posted by @nflaig in #6126 (comment)

@philknows philknows added prio-medium Resolve this some time soon (tm). scope-documentation All issues related to the Lodestar documentation. labels Nov 28, 2023
@philknows
Copy link
Member

Yeah the problem with pointing to master is that a lot of references in our code point to a specific tagged version of the consensus-specs for greater accuracy. We should be more proactive with updating these references though, outside of hard forks or another significant milestones (~1/year at this rate).

@philknows
Copy link
Member

I'll track this for around January. We should aim to do this sometime around each hard fork. Given that January/February we will be starting the transition to Deneb, we should update then.

@philknows philknows added the spec-deneb 🐡 Issues targeting the Deneb spec version label Dec 22, 2023
@philknows philknows self-assigned this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-documentation All issues related to the Lodestar documentation. spec-deneb 🐡 Issues targeting the Deneb spec version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants