Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow filtering of validators by top-level validator status #7141

Closed
nflaig opened this issue Oct 8, 2024 · 1 comment · Fixed by #7143
Closed

Allow filtering of validators by top-level validator status #7141

nflaig opened this issue Oct 8, 2024 · 1 comment · Fixed by #7143
Assignees
@vladmarusyk
Labels
good first issue Issues that are suitable for first-time contributors. hacktoberfest https://hacktoberfest.com/ help wanted The author indicates that additional help is wanted.

Comments

@nflaig
Copy link
Member

nflaig commented Oct 8, 2024

Right now, Lodestar does not support filtering response of getStateValidators by top-level validator statuses such as active as we only consider the more accurate sub statuses like active_ongoing, active_exiting and active_slashed.

As per beacon-api spec we should support active, pending, exited, and withdrawal (validators.yaml#L38).

Related code

lodestar/packages/beacon-node/src/api/impl/beacon/state/utils.ts

Line 132 in 955f456

export function filterStateValidatorsByStatus(

@nflaig nflaig added good first issue Issues that are suitable for first-time contributors. help wanted The author indicates that additional help is wanted. labels Oct 8, 2024
@vladmarusyk
Copy link
Contributor

vladmarusyk commented Oct 9, 2024 •
edited
Loading

Hello!

I would like to contribute to this issue as part of Hacktoberfest. Could you please add the hacktoberfest label to the issue so my contribution can count toward Hacktoberfest?

Thank you!

@wemeetagain wemeetagain added the hacktoberfest https://hacktoberfest.com/ label Oct 9, 2024
@vladmarusyk vladmarusyk mentioned this issue Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladmarusyk vladmarusyk

Labels
good first issue Issues that are suitable for first-time contributors. hacktoberfest https://hacktoberfest.com/ help wanted The author indicates that additional help is wanted.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow filtering of validators by top-level validator status vladmarusyk/lodestar
3 participants
@wemeetagain @nflaig @vladmarusyk