Display current links for a shared folder and allow to revoke them

[Tbaut]

For the owner of a shared folder, it is possible to create a link sharing for this bucket.
The "Manage bucket" modal should show any link sharing currently active, and allow the owner to delete them.

needs clarification: We should actually also let an owner create a link after the folder creation, most probably at the same place. We could have a dedicated issue for this.

Note - This issue does not include the changes to how existing share users are displayed, only the display/copying of a link.

[sweetpea22]

User opens manage share and has an active link. If no link is active, link management modal still appears, but "active link" line will change to "copy link" or "generate link".

If user retroactively adds edit permissions to an active link, we can indicate state change with button text content changing or color change.

Manage members can look like this, as the tag input could get unruly when lots of people are involved. Full access gives edit rights, plus share rights.

open to changes as always

[Tbaut]

This is a pretty big change, on top of adding the link sharing feature. I'll tackle the redesign in a separate issue I think.
Also just a nit, but we said the "Full access" can't be given to someone this way, at least not for now.

[FSM1]

Hey team! Please add your planning poker estimate with ZenHub @RyRy79261 @tanmoyAtb @Tbaut

[Tbaut]

Another suggestion @sweetpea22, we can have several links, say one for view only, the other for edit. So the design should maybe cater for several links. Could we have all the important things on 1 line

• link (truncated) - permission dropdown - Button to copy link - X to revoke ?

Also we don't have any other toggle in the UI, and I'm not sure this is well suited, when for the same permission setting, we have 2 different UI elements (a toggle and a dropdown)

[sweetpea22]

Also we don't have any other toggle in the UI, and I'm not sure this is well suited, when for the same permission setting, we have 2 different UI elements (a toggle and a dropdown)

Right, so I think toggle only makes sense if we republish permission changes to a single link because then users can be sure that one-click switch applies to the one link. But if we have multiple links it would make sense to use this dropdown, gives a better sense of differentiating what is selected. I'll get back to you with examples like you described

[Tbaut]

Nice thanks! Looking at something like this, maybe with a button to create a new link as well

[Tbaut]

I'll change this slightly, because changing the permission of a link is actually not supported, so I'll prevent this from happening, and just make sure the permission is set at the creation

[Tbaut]

@sweetpea22 I'll submit a PR with the following, let's make it nicer then :)

link-sharing.mp4