-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any node.js wizards want to lay out an initial project framework? #565
Comments
I can definitely work on that with someone |
I'm currently working on some other stuff, but I'll likely have some free time next week or earlier. I'd love to help then. |
What do we want to call the repo? Are we going to be using any particular naming format? |
Count me in on the node team. This weekend I'll have some time to contribute |
I'm currently busy, but I might be able to find some time to help. |
JS dev here too. |
We should call it |
@Chaosthebot/js-wizards team created 🎉 |
^ This, also. I think it would help to have a overview of what needs to be implemented, since it would be hard for me to simply translate the Python source. Do we need a simple wrapper around node-github? |
I think the first step is to replicate the core democracy functionality and then expand after that. I'd imagine the Node core would be ideal for any sort of web server needs, api endpoints, mongo/couch/nosql integration, etc. I'd also love for us to use graphql. I've been using it at work and it's just plain awesome. |
@Redmega I'd much rather keep the critical code in the core (updating bot from git) and isolate other non-critical components (web server, PR handling, issue/project commands) to other processes - this project shows roughly how I thought functionality should be split. |
Let me stop using the word "Core" everywhere. Auto updating and restarting would be controlled by |
I've now created the Chaosthebot/Chaos-Core repo. @Redmega It seems like the Node repo we're creating first is going to be the core, unless someone wants to write it in Python or another language instead. I don't necessarily think we should bundle together different parts of the bot in one repo per language. |
Maybe it might be better to separate via branch. |
I don't think per branch is a good idea. Branches usually separate versions of the same code. |
Yea if we are going to do different languages, it's got to be in different repos. |
So if we write this in nodejs, how do we plan to allow other modules (in Rust, Go, Python, etc) to launch and communicate? |
@mpnordland Child processes and IPC, but we'll need a standardised protocol for IPC and a format for knowing how to launch them. I've fixed the link. |
Maybe a modules.json which can be read to register modules map them to repos/endpoints/what-have-you. |
Maybe we can use something like |
I'm not experienced in node.js, so I was hoping to learn from some of you. Any node.js guys want to create a new repo and put down some scaffolding?
The text was updated successfully, but these errors were encountered: